Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman <ddstreet@xxxxxxxx> wrote:

> On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> >> because they are available for public use, per zpool.h?  If, e.g.,
> >> zram ever started using zpool, it would need them exported, wouldn't
> >> it?
> >
> > If you want to use it in ram export it in the same series as those
> > changes, and explain what the exprots are for in your message body.
> >
> 
> I don't want to use it in zram.  I wrote zpool, but neglected to
> export the functions.  They should be exported though.
> 
> What's your reasoning for not wanting them exported?

It's just noise which has no value.  Adding exports when there is a
demonstrated need is an OK approach.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]