On Fri 22-05-15 16:21:43, Michal Hocko wrote: > On Thu 21-05-15 13:09:09, Johannes Weiner wrote: [...] > > This makes a lot of sense to me. The only thing I worry about is the > > proliferation of PageHuge(), a function call, in relatively hot paths. > > I've tried that (see the patch below) but it enlarged the code by almost > 1k > text data bss dec hex filename > 510323 74273 44440 629036 9992c mm/built-in.o.before > 511248 74273 44440 629961 99cc9 mm/built-in.o.after > > I am not sure the code size increase is worth it. Maybe we can reduce > the check to only PageCompound(page) as huge pages are no in the page > cache (yet). Just to prevent from confusion. I means to reduce the check only for this particular case. But that is probably not worth the troubles either... -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>