On Tue, May 19, 2015 at 1:27 AM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, 18 May 2015 21:42:06 +0300 Leon Romanovsky <leon@xxxxxxx> wrote: > >> kenter/kleave/kdebug are wrapper macros to print functions flow and debug >> information. This set was written before pr_devel() was introduced, so >> it was controlled by "#if 0" construction. >> >> This patch refactors the current macros to use general pr_devel() >> functions which won't be compiled in if "#define DEBUG" is not declared >> prior to that macros. > > I doubt if anyone has used these in a decade and only a tenth of the > mm/nommu.c code is actually wired up to use the macros. A couple of days before, the question "how to handle such code" [1] was raised by me. Later, Joe Perches suggested to add into consideration the "delete option" [2]. > I'd suggest just removing it all. If someone later has a need, they > can add their own pr_devel() calls. My patch followed the preference of initial author (David Howells [3] and [4]). Please advise how should I proceed with it. [1] [RFC] Refactor kenter/kleave/kdebug macros - https://lkml.org/lkml/2015/5/16/279 [2] https://lkml.org/lkml/2015/5/16/280 [3] https://lkml.org/lkml/2015/5/18/199 [4] https://lkml.org/lkml/2015/5/18/457 Thanks. -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | leon@xxxxxxx -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>