On Mon, 2015-05-18 at 22:01 +0200, Borislav Petkov wrote: > On Mon, May 18, 2015 at 01:31:59PM -0600, Toshi Kani wrote: > > Well, #2 and #3 are independent. That is, uniform can be set regardless > > Not #2 and #3 above - the original #2 and #3 ones. I've written them out > detailed to show what I mean. The original #2 and #3 are set independently as well. They do not depend on each other condition being a specific value. > > The caller is responsible for verifying the conditions that are safe to > > create huge page. > > How is the caller ever going to be able to do anything about it? The caller is the one who makes the condition checks necessary to create a huge page mapping. mtrr_type_look() only returns how the given range is related with MTRRs. > Regardless, I'd prefer to not duplicate comments and rather put a short > sentence pointing the reader to the comments over mtrr_type_lookup() > where this all is being explained in detail. > > I'll fix it up. I appreciate your help. Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>