On Thu, 14 May 2015 10:20:08 +0800 kbuild test robot <fengguang.wu@xxxxxxxxx> wrote: > tree: git://git.cmpxchg.org/linux-mmotm.git master > head: e55a38145ac0946f090895afc5c8ba0717790908 > commit: add8ee4dd125729fb48d5cc73b194f28f1a6eccb [120/255] mm/thp: split out pmd collapse/flush into separate functions > config: m68k-multi_defconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout add8ee4dd125729fb48d5cc73b194f28f1a6eccb > # save the attached .config to linux build tree > make.cross ARCH=m68k > > All warnings: > > In file included from arch/m68k/include/asm/pgtable_mm.h:172:0, > from arch/m68k/include/asm/pgtable.h:4, > from include/linux/mm.h:53, > from include/linux/scatterlist.h:6, > from include/linux/dmaengine.h:24, > from include/linux/netdevice.h:38, > from net/batman-adv/main.h:168, > from net/batman-adv/bat_iv_ogm.c:18: > include/asm-generic/pgtable.h: In function 'pmdp_collapse_flush': > include/asm-generic/pgtable.h:206:2: warning: missing braces around initializer [-Wmissing-braces] > return __pmd(0); hm, yes, there is no requirement for the architecture to implement __pmd() and it shouldn't be used in include/linux. Will this work? --- a/include/asm-generic/pgtable.h~mm-thp-split-out-pmd-collpase-flush-into-a-separate-functions-fix-2 +++ a/include/asm-generic/pgtable.h @@ -203,7 +203,7 @@ static inline pmd_t pmdp_collapse_flush( pmd_t *pmdp) { BUILD_BUG(); - return __pmd(0); + return *pmdp; } #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>