Cyril, what about this to fix the rounding issue?
---
>From b83d740193490d78547197f47eee918732ed1f60 Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@xxxxxxx>
Date: Thu, 14 May 2015 11:08:20 +0200
Subject: [PATCH] controllers/memcg: Fix limit alignment expectations
since 3e32cb2e0a12 ("mm: memcontrol: lockless page counters") kernel
commit the limit_in_bytes is round down rather than up. This behavior
change has been discussed during the review and it was considered a
reasonable so fix the test accordingly.
While we are at it remove the test case 24 as it doesn't really test
anything more than test case 22.
Signed-off-by: Michal Hocko <mhocko@xxxxxxx>
---
.../kernel/controllers/memcg/functional/memcg_function_test.sh | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh b/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh
index cfc75fa730df..e3baf9d032f6 100755
--- a/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh
+++ b/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh
@@ -158,17 +158,12 @@ testcase_21()
# Case 22 - 24: Test limit_in_bytes will be aligned to PAGESIZE
testcase_22()
{
- test_limit_in_bytes $((PAGESIZE-1)) $PAGESIZE 0
+ test_limit_in_bytes $((PAGESIZE-1)) 0 0
}
testcase_23()
{
- test_limit_in_bytes $((PAGESIZE+1)) $((PAGESIZE*2)) 0
-}
-
-testcase_24()
-{
- test_limit_in_bytes 1 $PAGESIZE 0
+ test_limit_in_bytes $((PAGESIZE+1)) $((PAGESIZE)) 0
}
# Case 25 - 28: Test invaild memory.limit_in_bytes
--
2.1.4
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>