On Tue, May 12, 2015 at 02:04:55AM -0700, Naoya Horiguchi wrote:
> On Tue, May 12, 2015 at 11:43:39AM +0300, Dan Carpenter wrote:
> > On Mon, May 11, 2015 at 11:54:44PM +0000, Naoya Horiguchi wrote:
> > > @@ -1086,7 +1086,8 @@ static void dissolve_free_huge_page(struct page *page)
> > > */
> > > void dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn)
> > > {
> > > - unsigned int order = 8 * sizeof(void *);
> > > + /* Initialized to "high enough" value which is capped later */
> > > + unsigned int order = 8 * sizeof(void *) - 1;
> >
> > Why not use UINT_MAX? It's more clear that it's not valid that way.
>
> It's OK if code checker doesn't show "too much right shift" warning.
It's a comlicated question to answer but with the new VM_BUG_ON() then
it won't warn.
regards,
dan carpenter
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>