On Mon, May 11, 2015 at 02:29:24PM +0300, Dan Carpenter wrote:
> On Mon, May 11, 2015 at 02:17:48PM +0300, Dan Carpenter wrote:
> > Hello Naoya Horiguchi,
> >
> > The patch c8721bbbdd36: "mm: memory-hotplug: enable memory hotplug to
> > handle hugepage" from Sep 11, 2013, leads to the following static
> > checker warning:
> >
> > mm/hugetlb.c:1203 dissolve_free_huge_pages()
> > warn: potential right shift more than type allows '9,18,64'
> >
> > mm/hugetlb.c
> > 1189 void dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn)
> > 1190 {
> > 1191 unsigned int order = 8 * sizeof(void *);
> > ^^^^^^^^^^^^^^^^^^
> > Let's say order is 64.
>
> Actually, the 64 here is just chosen to be an impossibly high number
> isn't it?
Right.
> It's a bit complicated to understand that at first glance.
OK, so I added oneline comment in the patch in another email.
Thanks,
Naoya Horiguchi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href