Hi Pavel, Thanks a lot for taking the time to review this. On Sat, May 9, 2015 at 5:44 PM, Pavel Machek <pavel@xxxxxx> wrote: >> +#ifdef CONFIG_SANITIZE_FREED_PAGES >> + clear_free_pages(); >> + printk(KERN_INFO "PM: free pages cleared after restore\n"); >> +#endif >> + } >> platform_leave(platform_mode); >> >> Power_up: > > Can you move the ifdef and the printk into the clear_free_pages? Sure. I put the printk out originally because i thought there might be other uses, but since this is the sole call site right now it shouldn't be an issue. > > This is not performance critical in any way... > > Otherwise it looks good to me... if the sanitization is considered > useful. Did it catch some bugs in the past? > I've read somewhere that users of grsecurity claim that it caught bugs in some drivers, but I haven't verified that personally; it's probably much less useful than kasan (or even the original grsec feature) as a bug-catcher since it doesn't clear freed slab buffers. I'll wait a few more days for more reviews before sending the next version, particularly on the power management part, and in general on the usefulness of such feature. Regards, Anisse -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>