On Wed, May 6, 2015 at 4:30 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > Gramatically, a function called "memblock_has_mirror()" should return a > bool. This guy is misnamed. "memblock_mirror_flag()"? My misnaming is worse than that ... the intent here is to check whether there is any mirrored memory in the system ... i.e. should we go looking around among memblocks for mirrored memory - or is that a futile quest. Most systems won't have any mirror memory - so we won't want to spam the console logs with a ton of messages about not being able to allocate mirrored memory. I'll rename it to "system_has_mirror_memory()". I'll fix all the other things too and re-spin. Keeping to 80 columns might be challenging in some places. -Tony -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>