On Thu, 2015-05-07 at 00:39 +0200, Borislav Petkov wrote: > On Wed, May 06, 2015 at 09:23:31AM -0600, Toshi Kani wrote: > > I have a question. Those bits define the bit field of enabled in struct > > mtrr_state_type, which is defined in this header. Is it OK to only move > > those definitions to other header? > > I think we shouldn't expose stuff to userspace if we don't have to > because then we're stuck with it. Userspace has managed so far without > those defines so I don't see why we should export them now. OK, I will move those bits definition to arch/x86/include/asm/mtrr.h. Thanks for the clarification, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>