On Tue, Apr 28, 2015 at 06:48:10AM -0700, Andrew Morton wrote: > On Tue, 28 Apr 2015 10:53:23 +0100 Mel Gorman <mgorman@xxxxxxx> wrote: > > > > > +#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > > > > +#define __defermem_init __meminit > > > > +#define __defer_init __meminit > > > > +#else > > > > +#define __defermem_init > > > > +#define __defer_init __init > > > > +#endif > > > > > > Could we get some comments describing these? What they do, when and > > > where they should be used. I have a suspicion that the naming isn't > > > good, but I didn't spend a lot of time reverse-engineering the > > > intent... > > > > > > > Of course. The next version will have > > > > +/* > > + * Deferred struct page initialisation requires some early init functions that > > + * are removed before kswapd is up and running. The feature depends on memory > > + * hotplug so put the data and code required by deferred initialisation into > > + * the __meminit section where they are preserved. > > + */ > > I'm still not getting it even a little bit :( You say "data and code", > so I'd expect to see > > #define __defer_meminitdata __meminitdata > #define __defer_meminit __meminit > > But the patch doesn't mention the data segment at all. > Take 2. Suggestions on different names are welcome because they are poor. /* * Deferred struct page initialisation requires init functions that are freed * before kswapd is available. Reuse the memory hotplug section annotation * to mark the required code. * * __defermem_init is code that always exists but is annotated __meminit to * avoid section warnings. * __defer_init code gets marked __meminit when deferring struct page * initialistion but is otherwise in the init section. */ -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>