On Mon, Apr 27, 2015 at 03:43:56PM -0700, Andrew Morton wrote: > On Thu, 23 Apr 2015 11:33:14 +0100 Mel Gorman <mgorman@xxxxxxx> wrote: > > > Parallel struct page frees pages one at a time. Try free pages as single > > large pages where possible. > > > > ... > > > > void __defermem_init deferred_init_memmap(int nid) > > This function is gruesome in an 80-col display. Even the code comments > wrap, which is nuts. Maybe hoist the contents of the outermost loop > into a separate function, called for each zone? I can do better than that because only the highest zone is deferred in this version and the loop is no longer necessary. I should post a V4 before the end of my day that addresses your feedback. It caused a lot of conflicts and it'll be easier to replace the full series than try managing incremental fixes. Thanks Andrew. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>