Re: [PATCH 9/9] tools lib traceevent: Honor operator priority

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 07, 2015 at 10:02:08AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Apr 07, 2015 at 04:52:26PM +0900, Namhyung Kim escreveu:
> > On Mon, Apr 06, 2015 at 10:45:04AM -0400, Steven Rostedt wrote:
> > > >  		type = process_arg_token(event, right, tok, type);
> > > > -		arg->op.right = right;
> > > > +
> > > > +		if (right->type == PRINT_OP &&
> > > > +		    get_op_prio(arg->op.op) < get_op_prio(right->op.op)) {
> > > > +			struct print_arg tmp;
> > > > +
> > > > +			/* swap ops according to the priority */
> 
> > > This isn't really a swap. Better term to use is "rotate".
> 
> > You're right!
> 
> > > But other than that,
> 
> > > Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > 
> > Thanks for the review
> 
> Ok, so just doing that s/swap/rotate/g, sticking Rostedt's ack and
> applying, ok?

Sure thing!

Thanks for your work,
Namhyung

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]