On Wed, Mar 25, 2015 at 12:40:44PM +0200, Boaz Harrosh wrote: > On 03/25/2015 11:41 AM, Dave Chinner wrote: > > On Wed, Mar 25, 2015 at 10:31:22AM +0200, Boaz Harrosh wrote: > >> On 03/25/2015 04:26 AM, Dave Chinner wrote: > <> > >> sync and fsync should and will work correctly, but this does not > >> solve our problem. because what turns pages to read-only is the > >> writeback. And we do not have this in dax. Therefore we need to > >> do this here as a special case. > > > > We can still use exactly the same dirty tracking as we use for data > > writeback. The difference is that we don't need to go through all > > teh page writeback; we can just flush the CPU caches and mark all > > the mappings clean, then clear the I_DIRTY_PAGES flag and move on to > > inode writeback.... > > > > I see what you mean. the sb wide sync will not step into mmaped inodes > and fsync them. > > If we go my way and write NT (None Temporal) style in Kernel. > NT instructions exist since xeon and all the Intel iX core CPUs have > them. In tests we conducted doing xeon NT-writes vs > regular-writes-and-cl_flush at .fsync showed minimum of 20% improvement. > That is on very large IOs. On 4k IOs it was even better. As I said before, relying on specific instructions is a non-starter for mmap writes, and that's the problem we need to solve here. > It looks like you have a much better picture in your mind how to > fit this properly at the inode-dirty picture. Can you attempt a rough draft? > > If we are going the NT way. Then we can only I_DIRTY_ track the mmaped > inodes. For me this is really scary because I do not want to trigger > any writeback threads. If you could please draw me an outline (or write > something up ;-)) it would be great. Writeback threads are not used for fsync - they are used for sync and background writeback. They are already active on DAX filesystems that track dirty inodes on the VFS superblock, as this is the way inodes are written back on some filesystems. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>