At Tue, 24 Mar 2015 09:13:39 -0700, Joe Perches wrote: > > On Tue, 2015-03-24 at 22:10 +0900, Hajime Tazaki wrote: > > libos (arch/lib) emulates a sysctl-like interface by a function call of > > userspace by enumerating sysctl tree from sysctl_table_root. It requires > > to be publicly accessible to this symbol and related functions. > [] > > diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c > [] > > @@ -77,7 +77,7 @@ static int namecmp(const char *name1, int len1, const char *name2, int len2) > > } > > > > /* Called under sysctl_lock */ > > -static struct ctl_table *find_entry(struct ctl_table_header **phead, > > +struct ctl_table *find_entry(struct ctl_table_header **phead, > > find_entry and all of the <foo>_entry functions below it > are overly generic names. Maybe prefix with ctl_table_ agree. I will address this in the next version of the patch. thanks. -- Hajime -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>