On Thu, 2015-03-12 at 11:03 +0000, Ingo Molnar wrote: > * Toshi Kani <toshi.kani@xxxxxx> wrote: > > > > Did it perhaps want to be the other way around: > > > > > > if (mtrr_state.have_fixed && (start < 0x1000000)) { > > > ... > > > } else if (start < 0x100000) { > > > ... > > > > > > or did it simply mess up the condition? > > > > I think it was just paranoid to test the same condition twice... > > Read the code again, it's _not_ the same condition ... Oh, I see... It must be a typo. The fixed range is 0x0 to 0xFFFFF, so it only makes sense to check with (start < 0x100000). Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>