On Wed, 2015-03-04 at 23:09 +0100, Ingo Molnar wrote: > * Toshi Kani <toshi.kani@xxxxxx> wrote: : > Hm, so I don't see where you set the proper x86 PAT table attributes > for the pmds. > > MTRR's are basically a legacy mechanism, the proper way to set cache > attribute is PAT and I don't see where this generic code does that, > but I might be missing something? It's done by x86 code, not by this generic code. __ioremap_caller() takes page_cache_mode and converts it to pgprot_t using the PAT table attribute. It then calls this generic func, ioremap_page_range(). When creating a huge page mapping, pud_set_huge() and pmd_set_huge() handle the relocation of the PAT bit. Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>