On Tue 24-02-15 14:11:27, Johannes Weiner wrote: [...] > I'm fine with keeping the allocation looping, but is that message > helpful? It seems completely useless to the user encountering it. Is > it going to help kernel developers when we get a bug report with it? It is better than a silent endless loop. And we get a trace which points to the place which is doing the allocation. We haven't seen any weird crashes during suspend throughout last 6 years so this would be extremely unlikely and hard to reproduce so having the trace sounds useful to me. > WARN_ON_ONCE()? I do not expect this will spew a lot of messages. But I can live with WARN_ON_ONCE as well. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>