On Thu, Jan 22, 2015 at 08:23:08AM -0500, Brian Foster wrote: > On Thu, Jan 08, 2015 at 09:25:41AM +1100, Dave Chinner wrote: > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > index 8be5bb5..f491860 100644 > > --- a/fs/xfs/xfs_iops.c > > +++ b/fs/xfs/xfs_iops.c > > @@ -768,7 +768,7 @@ xfs_setattr_size( > > if (error) > > return error; > > > > - ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL)); > > + ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL|XFS_MMAPLOCK_EXCL)); > > Only debug code of course, but xfs_isilocked() doesn't appear to support > what is intended by this call (e.g., verification of multiple locks). Ah, right. Didn't think that one though properly. I'll fix it up. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>