On Mon, 12 Jan 2015 15:53:11 +0000 David Vrabel <david.vrabel@xxxxxxxxxx> wrote: > These two patches are the common parts of a larger Xen series[1] > fixing several long-standing bugs the handling of foreign[2] pages in > Xen guests. > > The first patch is required to fix get_user_pages[_fast]() with > userspace space mappings of such foreign pages. Basically, pte_page() > doesn't work so an alternate mechanism is needed to get the page from > a VMA and address. By requiring mappings needing this method are > 'special' this should not have an impact on the common use cases. > > The second patch isn't essential but helps with readability of the > resulting user of the page flag. > > For further background reading see: > > http://xenbits.xen.org/people/dvrabel/grant-improvements-C.pdf > Looks OK to me. I can merge them if you like, but it's probably more convenient for you to include them in the Xen tree. It would be nice if PG_foreign (and PG_everythingelse) was properly documented at the definition site. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>