On 01/06/2015 04:09 PM, Michal Hocko wrote: > On Mon 05-01-15 18:17:43, Vlastimil Babka wrote: >> The function next_zones_zonelist() returns zoneref pointer, as well as zone >> pointer via extra parameter. Since the latter can be trivially obtained by >> dereferencing the former, the overhead of the extra parameter is unjustified. >> >> This patch thus removes the zone parameter from next_zones_zonelist(). Both >> callers happen to be in the same header file, so it's simple to add the >> zoneref dereference inline. We save some bytes of code size. > > Dunno. It makes first_zones_zonelist and next_zones_zonelist look > different which might be a bit confusing. It's not a big deal but > I am not sure it is worth it. Yeah I thought that nobody uses them directly anyway thanks to for_each_zone_zonelist* so it's not a big deal. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>