On Tue, Jan 06, 2015 at 06:43:49PM +0100, Vlastimil Babka wrote: > On 01/05/2015 12:46 PM, Kirill A. Shutemov wrote: > > The only caller is __free_one_page(). By the time we should have > > page->flags to be cleared already: > > > > - for 0-order pages though PCP list: > > Can there even be a 0-order compound page? I guess not, so this is just confusing? No, it can't. Since I propose the VM_BUG_ON(page->flags), I tried to make point that flags are cleared by the point in any case. > Otherwise it seems like you are right and it's a dead code to be removed. I > tried to check history to see when it was actually needed, but seems it predates > git. Yeah. But we keep updating it... -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>