On 12/30/2014 07:45 AM, Andi Kleen wrote: > Andrzej Hajda <a.hajda@xxxxxxxxxxx> writes: > >> kstrdup if often used to duplicate strings where neither source neither >> destination will be ever modified. In such case we can just reuse the source >> instead of duplicating it. The problem is that we must be sure that >> the source is non-modifiable and its life-time is long enough. > What happens if someone is to kfree() these strings? > > -Andi > kstrdup_const must be accompanied by kfree_const, I did not mention it in cover letter but it is described in the 1st patch commit message. Simpler alternative (but I am not sure if better) would be to add similar check (ie. if pointer is in .rodata) to kfree itself. Regards Andrzej -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>