On Sun, Dec 28, 2014 at 02:00:20PM -0500, Johannes Weiner wrote: > On Sun, Dec 28, 2014 at 07:19:12PM +0300, Vladimir Davydov wrote: > > The design of swap limits for memory cgroups looks broken. Instead of a > > separate swap limit, there is the memory.memsw.limit_in_bytes knob, > > which limits total memory+swap consumption. As a result, under global > > memory pressure, a cgroup can eat up to memsw.limit of *swap*, so it's > > just impossible to set the swap limit to be less than the memory limit > > with such a design. In particular, this means that we have to leave swap > > unlimited if we want to partition system memory dynamically using soft > > limits. > > > > This patch therefore attempts to move from memory+swap to pure swap > > accounting so that we will be able to separate memory and swap resources > > in the sane cgroup hierarchy, which is the business of the following > > patch. > > > > The old interface acts on memory and swap limits as follows: > > The implementation seems fine to me, but there is no point in cramming > this into the old interface. Let's just leave it alone and implement > proper swap accounting and limiting in the default/unified hierarchy. Agree - the patch will be cleaner, and we won't need to bother about compatibility issues then. Thanks, Vladimir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>