On Sun 23-11-14 13:52:48, Tetsuo Handa wrote: [...] > This patch drops __GFP_WAIT flag when allocating from shrinker functions > so that recursive __alloc_pages_nodemask() calls will not cause troubles > like recursive locks and/or unpredictable sleep. The comments in this patch > suggest shrinker functions users to try to avoid use of sleepable locks > and memory allocations from shrinker functions, as with TTM driver's > shrinker functions. Again, you are just papering over potential bugs. Those bugs should be identified and fixe _properly_ (like stop calling kmalloc in the bug referenced in your changelog) rather than dropping gfp flags behind requester back. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>