On Thu, Nov 20, 2014 at 09:08:33PM +0800, Mahendran Ganesh wrote: > In zs_create_pool(), prev_class is assigned (ZS_SIZE_CLASSES - 1) > times. And the prev_class only references to the previous alloc > size_class. So we do not need unnecessary assignement. > > This patch modifies *prev_class* to *prev_alloc_class*. And the > *prev_alloc_class* will only be assigned when a new size_class > structure is allocated. > > Signed-off-by: Mahendran Ganesh <opensource.ganesh@xxxxxxxxx> > --- > mm/zsmalloc.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index b3b57ef..ac2b396 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -970,7 +970,7 @@ struct zs_pool *zs_create_pool(gfp_t flags) > int size; > int pages_per_zspage; > struct size_class *class; > - struct size_class *prev_class; > + struct size_class *uninitialized_var(prev_alloc_class); https://lkml.org/lkml/2012/10/27/71 In addition, I prefer prev_class. Thanks. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>