On 11/10/2014 03:22 PM, Linus Torvalds wrote: > Rik, the fact that you acked this just makes all your other ack's be > suspect. Did you do it just because it was from Red Hat, or do you do > it because you like seeing Acked-by's with your name? I acked it because I could not come up with a better idea on how to solve this problem. Keeping the device page tables in sync with the CPU page tables (and sometimes different, when a page is migrated from system DRAM to VRAM) will require either expanded macros and generic walker functions like this, or trusting the device driver writers to correctly copy over example code and implement their own... I have seen too much copied-and-slightly modified code in drivers to develop a dislike for the second alternative. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>