-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/06/2014 05:40 PM, Jerome Glisse wrote: > On Thu, Nov 06, 2014 at 05:32:00PM -0500, Rik van Riel wrote: > Never a fan of preprocessor magic, but I see why it's needed. > > Acked-by: Rik van Riel <riel@xxxxxxxxxx> > >> v1 is not using preprocessor but has a bigger gpt struct >> footprint and also more complex calculation for page table >> walking due to the fact that i just rely more on runtime >> computation than on compile time shift define through >> preprocessor magic. > >> Given i am not a fan either of preprocessor magic if it makes you >> feel any better i can resort to use v1, both have seen same kind >> of testing and both are functionaly equivalent (API they expose >> is obviously slightly different). > >> I am not convince that what the computation i save using >> preprocessor will show up in anyway as being bottleneck for hot >> path. I have no strong preference either way. This code is perfectly readable. Andrew? - -- All rights reversed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUW/yGAAoJEM553pKExN6DqcwIAJAh8mUCOuzyhqJl21qMGWu9 FwL8qEUCxxXxLuX2MFv/wbkb07+OLI8nStI5rPxk6qUdC53YV4Bc7CWfvwF4slRB hpPVGhmNKj4e5jwP+d8/MMSd6QfGA/jaiiRw9IxasOxzYKJxtKW4wAsme+qiDy6Y i59sGQndVUstP6Zf5ZnaKN7BkG57daQqwypktPpMf7CQxv2uN5nnErDDFzhvm8Qz tCcKtpsdZgek7l6RPaovvRHi0kT3L67gq5oIFuS9iiHGqhmohpj2sTENafLeWUb1 zGdjy8EcxBL5H0L1/wxs3PWjyKez1q/wEZJ390+wmRaMBWl1WqbGsAZ1uZ98bd0= =ZAbm -----END PGP SIGNATURE----- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>