On Wed, 2014-10-29 at 10:42 +0800, Wang, Yalin wrote: > > Use the inline function instead of directly indexing the array. > > This allows some architectures with hardware instructions for bit reversals > > to eliminate the array. [] > > On Sun, 2014-10-26 at 23:46 -0700, Joe Perches wrote: > > > On Mon, 2014-10-27 at 14:37 +0800, Wang, Yalin wrote: > > > > this change add CONFIG_HAVE_ARCH_BITREVERSE config option, so that > > > > we can use arm/arm64 rbit instruction to do bitrev operation by > > > > hardware. [] > I think the most safe way is change byte_rev_table[] to be satic, > So that no driver can access it directly, > The build error can remind the developer if they use byte_rev_table[] > Directly . You can do that with your later patch, but the existing uses _must_ be converted first so you don't break the build. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>