On Wed, 22 Oct 2014 21:45:52 +0200 Dominik Dingel <dingel@xxxxxxxxxxxxxxxxxx> wrote: > > > +#ifndef mm_forbids_zeropage > > > +#define mm_forbids_zeropage(X) (0) > > > +#endif > > > > Can we document this please? What it does, why it does it. We should > > also specify precisely which arch header file is responsible for > > defining mm_forbids_zeropage. > > > > I will add a comment like: > > /* > * To prevent common memory management code establishing > * a zero page mapping on a read fault. > * This function should be implemented within <asm/pgtable.h>. s/function should be implemented/macro should be defined/ > * s390 does this to prevent multiplexing of hardware bits > * related to the physical page in case of virtualization. > */ > > Okay? Looks great, thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>