On Sun, Oct 19, 2014 at 01:27:37PM -0400, David Miller wrote: > From: Sam Ravnborg <sam@xxxxxxxxxxxx> > Date: Sun, 19 Oct 2014 17:32:20 +0200 > > > This part: > > > >> + __attribute__ ((aligned(64))); > > > > Could be written as __aligned(64) > > I'll try to remember to sweep this up in sparc-next, thanks Sam. > > We probably use this long-hand form in a lot of other places in > the sparc code too, so I'll try to do a full sweep. Another related one would be a full sweep of "__asm__ __volatile__" to the shorter version "asm volatile". The latter is used in a few places in sparc already - so toolchain supports it. I got hits in: include/asm/irqflags_32.h: asm volatile("rd %%psr, %0" : "=r" (flags)); include/asm/processor_64.h:#define cpu_relax() asm volatile("\n99:\n\t" \ kernel/kprobes.c: asm volatile(".global kretprobe_trampoline\n" But this would touch 93 files. Thats too much crunch :-( Sam -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>