On 10/16/2014 12:32 AM, Andrew Morton wrote:
> On Tue, 7 Oct 2014 17:33:36 +0200 Vlastimil Babka <vbabka@xxxxxxx> wrote:
>> @@ -105,8 +104,7 @@ static inline bool compaction_restarting(struct zone *zone, int order)
>> static inline unsigned long try_to_compact_pages(struct zonelist *zonelist,
>> int order, gfp_t gfp_mask, nodemask_t *nodemask,
>> enum migrate_mode mode, int *contended,
>> - int alloc_flags, int classzone_idx,
>> - struct zone **candidate_zone)
>> + int alloc_flags, int classzone_idx);
>> {
>> return COMPACT_CONTINUE;
>> }
>
> --- a/include/linux/compaction.h~mm-compaction-simplify-deferred-compaction-fix
> +++ a/include/linux/compaction.h
> @@ -104,7 +104,7 @@ static inline bool compaction_restarting
> static inline unsigned long try_to_compact_pages(struct zonelist *zonelist,
> int order, gfp_t gfp_mask, nodemask_t *nodemask,
> enum migrate_mode mode, int *contended,
> - int alloc_flags, int classzone_idx);
> + int alloc_flags, int classzone_idx)
> {
> return COMPACT_CONTINUE;
> }
>
> It clearly wasn't tested with this config. Please do so and let us
> know the result?
Sorry, forgot. Hopefully will get better next time, since I learned
about the undertaker/vampyr tool [1] today.
You patch does fix the compilation, thanks. Boot+stress-highalloc tests
are now running through the series but I don't expect any surprises -
the series is basically a no-op with CONFIG_COMPACTION disabled.
[1] http://lwn.net/Articles/616098/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>