Hi Steve, On Fri, Sep 26, 2014 at 03:03:48PM +0100, Steve Capper wrote: > This patch provides a general RCU implementation of get_user_pages_fast > that can be used by architectures that perform hardware broadcast of > TLB invalidations. > > It is based heavily on the PowerPC implementation by Nick Piggin. It'd be nice if you could also at the same time apply it to sparc and powerpc in this same patchset to show the effectiveness of having a generic version. Because if it's not a trivial drop-in replacement, then this should go in arch/arm* instead of mm/gup.c... Also I wonder if it wouldn't be better to add it to mm/util.c along with the __weak gup_fast but then this is ok too. I'm just saying because we never had sings of gup_fast code in mm/gup.c so far but then this isn't exactly a __weak version of it... so I don't mind either ways. > + down_read(&mm->mmap_sem); > + ret = get_user_pages(current, mm, start, > + nr_pages - nr, write, 0, pages, NULL); > + up_read(&mm->mmap_sem); This has a collision with a patchset I posted, but it's trivial to solve, the above three lines need to be replaced with: + ret = get_user_pages_unlocked(current, mm, start, + nr_pages - nr, write, 0, pages); And then arm gup_fast will also page fault with FOLL_FAULT_ALLOW_RETRY the first time to release the mmap_sem before I/O. Thanks, Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>