On Tue, 30 Sep 2014, Vlastimil Babka wrote: > On 09/29/2014 05:30 AM, Xiubo Li wrote: > > Setting 'flags' to zero will be certainly a misleading way to avoid > > warning of 'flags' may be used uninitialized. uninitialized_var is > > a correct way because the warning is a false possitive. > > Agree. > > > Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx> > > Acked-by: Vlastimil Babka <vbabka@xxxxxxx> > I thought we just discussed this when mm-compaction-fix-warning-of-flags-may-be-used-uninitialized.patch was merged and, although I liked it, it was stated that we shouldn't add any new users of uninitialized_var(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>