On Sep 24, 2014 2:59 PM, "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, 20 Sep 2014 01:03:07 -0700 Peter Feiner <pfeiner@xxxxxxxxxx> wrote:
>
> > Fixes the same bug as b43790eedd31e9535b89bbfa45793919e9504c34 and
> > 9aed8614af5a05cdaa32a0b78b0f1a424754a958 where the return value of
> > pte_*mksoft_dirty was being ignored.
> >
> > To be sure that no other pte/pmd "mk" function return values were
> > being ignored, I annotated the functions in
> > arch/x86/include/asm/pgtable.h with __must_check and rebuilt.
> >
>
> Grumble.
>
> It is useful to identify preceding similar patches but that isn't a
> good way of describing *this* patch. What is wrong with the current
> code, how does the patch fix it.
>
> And, particularly, what do you think are the end-user visible effects
> of the bug? This info helps people to work out which kernel versions
> need the fix.
>
Let me think about this and cook up a test case. I'll submit a v2 with a better description.
Peter