On Tue, 23 Sep 2014 16:40:24 +0800 kbuild test robot <fengguang.wu@xxxxxxxxx> wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 55f21306900abf9f9d2a087a127ff49c6d388ad2 > commit: 7bb72683b1708c3cf3bea0575c0e80314a2232dc [7267/7446] rtc: bq32000: add trickle charger option, with device tree binding > config: i386-randconfig-ib0-09231629 (attached as .config) > reproduce: > git checkout 7bb72683b1708c3cf3bea0575c0e80314a2232dc > # save the attached .config to linux build tree > make ARCH=i386 > > Note: it may well be a FALSE warning. FWIW you are at least aware of it now. > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings > > All warnings: > > drivers/rtc/rtc-bq32k.c: In function 'trickle_charger_of_init': > drivers/rtc/rtc-bq32k.c:155:7: warning: assignment makes pointer from integer without a cast > reg = 0x05; > ^ > drivers/rtc/rtc-bq32k.c:165:7: warning: assignment makes pointer from integer without a cast > reg = 0x25; > ^ > drivers/rtc/rtc-bq32k.c:177:6: warning: assignment makes pointer from integer without a cast > reg = 0x20; > ^ > drivers/rtc/rtc-bq32k.c:135:6: warning: unused variable 'plen' [-Wunused-variable] > int plen = 0; > ^ > drivers/rtc/rtc-bq32k.c: In function 'bq32k_probe': > >> drivers/rtc/rtc-bq32k.c:169:3: warning: 'setup' may be used uninitialized in this function [-Wmaybe-uninitialized] > dev_err(dev, "invalid resistor value (%d)\n", *setup); > ^ > drivers/rtc/rtc-bq32k.c:136:18: note: 'setup' was declared here > const uint32_t *setup; Pavel's changelog failed to tell us what warnings were being fixed (bad!) but I expect the below will fix this. From: Pavel Machek <pavel@xxxxxx> Subject: drivers/rtc/rtc-bq32k.c fix warnings I introduced Sorry about that, I somehow failed to notice rather severe warnings. Signed-off-by: Pavel Machek <pavel@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-bq32k.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff -puN drivers/rtc/rtc-bq32k.c~rtc-bq32000-add-trickle-charger-option-with-device-tree-binding-fix drivers/rtc/rtc-bq32k.c --- a/drivers/rtc/rtc-bq32k.c~rtc-bq32000-add-trickle-charger-option-with-device-tree-binding-fix +++ a/drivers/rtc/rtc-bq32k.c @@ -132,9 +132,7 @@ static const struct rtc_class_ops bq32k_ static int trickle_charger_of_init(struct device *dev, struct device_node *node) { - int plen = 0; - const uint32_t *setup; - const uint32_t *reg; + unsigned char reg; int error; u32 ohms = 0; @@ -166,7 +164,7 @@ static int trickle_charger_of_init(struc break; default: - dev_err(dev, "invalid resistor value (%d)\n", *setup); + dev_err(dev, "invalid resistor value (%d)\n", ohms); return -EINVAL; } _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>