Hi, > > Arnd Bergmann already sent a patch for this to use uninitialized_var() > > privately but it didn't get cc'd to any mailing list, sorry. > > Besides that setting flags to 0 is certainly a misleading way to fix > this issue. uninitialized_var is a correct way because the warning is a > false possitive. compact_unlock_should_abort will not touch the flags if > locked is false and this is true only after a lock has been taken and > flags set. (this should be preferably in the patch description). > Yes, right. This should be added to the commit comment with the patch. Thanks, BRs Xiubo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href