On Wed, Sep 10, 2014 at 04:36:28PM -0700, Andrew Morton wrote: > On Wed, 10 Sep 2014 16:24:46 -0700 Peter Feiner <pfeiner@xxxxxxxxxx> wrote: > > @@ -1048,32 +1048,51 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > > + while (1) { > > + unsigned long vm_start = end; > > Did you really mean to do that? If so, perhaps a little comment to > explain how it works? It's the same idea that I used in the pagemap_pte_hole patch that I submitted today: if vma is NULL, then we fill in the pagemap from (addr) to (end) with non-present pagemap entries. Should I submit a v2 with a comment? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>