Hi Christoph, On 14.08.2014 [13:06:56 -0700], Nishanth Aravamudan wrote: > On 14.08.2014 [09:35:37 -0500], Christoph Lameter wrote: > > On Wed, 13 Aug 2014, Nishanth Aravamudan wrote: > > > > > +++ b/include/linux/topology.h > > > @@ -119,11 +119,20 @@ static inline int numa_node_id(void) > > > * Use the accessor functions set_numa_mem(), numa_mem_id() and cpu_to_mem(). > > > */ > > > DECLARE_PER_CPU(int, _numa_mem_); > > > +extern int _node_numa_mem_[MAX_NUMNODES]; > > > > Why are these variables starting with an _ ? > > Maybe _numa_mem was defined that way because it is typically not defined. > > We dont do this in other situations. > > That's how it was in Joonsoo's patch and I was trying to minimize the > changes from his version (beyond making it compile). I can of course > update it to not have a prefixing _ if that's preferred. Upon reflection, did you mean all of these variables? Would you rather I submitted a follow-on patch that removed the prefix _? Note that _node_numa_mem_ is also not defined if !MEMORYLESS_NODES. -Nish -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>