On Thu, Aug 14, 2014 at 11:09 AM, Dan Streetman <ddstreet@xxxxxxxx> wrote:
> On Wed, Aug 13, 2014 at 9:12 PM, Minchan Kim <minchan@xxxxxxxxxx> wrote:
>> - if (zram->limit_bytes &&
>> - zs_get_total_size_bytes(meta->mem_pool) > zram->limit_bytes) {
>> + total_bytes = zs_get_total_size_bytes(meta->mem_pool);
>> + if (zram->limit_bytes && total_bytes > zram->limit_bytes) {
>
> do you need to take the init_lock to read limit_bytes here? It could
> be getting changed between these checks...
There is no real danger in freeing with an error.
It is more timing than a race.
The max calculation is still ok because committed allocations are
added atomically.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>