On 08/05/2014 09:04 PM, Sasha Levin wrote: > Thanks Hugh, Mel. I've added both patches to my local tree and will update tomorrow > with the weather. > > Also: > > On 08/05/2014 08:42 PM, Hugh Dickins wrote: >> One thing I did wonder, though: at first I was reassured by the >> VM_BUG_ON(!pte_present(pte)) you add to pte_mknuma(); but then thought >> it would be better as VM_BUG_ON(!(val & _PAGE_PRESENT)), being stronger >> - asserting that indeed we do not put NUMA hints on PROT_NONE areas. >> (But I have not tested, perhaps such a VM_BUG_ON would actually fire.) > > I've added VM_BUG_ON(!(val & _PAGE_PRESENT)) in just as a curiosity, I'll > update how that one looks as well. Sorry for the rather long delay. The patch looks fine, the issue didn't reproduce. The added VM_BUG_ON didn't trigger either, so maybe we should consider adding it in. Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>