Ok if the crypto request_module is changed it makes more sense to change zpool's use of request_module; it looks like there are a couple other places in the kernel using prefixes/aliases (although it's not universal). I still suggest moving the MODULE_ALIAS() into zbud/zsmalloc's #ifdef CONFIG_ZPOOL, though. On Fri, Aug 8, 2014 at 11:08 PM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Aug 08, 2014 at 05:06:41PM -0700, Kees Cook wrote: >> >> I think we need to fix zswap now before it gets too far, and likely >> adjust the crypto API to use a module prefix as well. Perhaps we need >> a "crypto-" prefix? > > Yes I think a crypto- prefix would make sense. Most crypto > algorithms should be providing an alias already so it's mostly > just changing the aliases. > > Patches are welcome :) > > Thanks, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>