On Thu, 7 Aug 2014 12:25:07 -0400 Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > mem_cgroup_migrate() is suitable for replace_page_cache() as well, > which gets rid of mem_cgroup_replace_page_cache(). > > Could you please update it to say: > > mem_cgroup_migrate() is suitable for replace_page_cache() as well, > which gets rid of mem_cgroup_replace_page_cache(). However, care > needs to be taken because both the source and the target page can > already be charged and on the LRU when fuse is splicing: grab the page > lock on the charge moving side to prevent changing pc->mem_cgroup of a > page under migration. Also, the lruvecs of both pages change as we > uncharge the old and charge the new during migration, and putback may > race with us, so grab the lru lock and isolate the pages iff on LRU to > prevent races and ensure the pages are on the right lruvec afterward. OK thanks, I did that, separated out mm-memcontrol-rewrite-uncharge-api-fix-page-cache-migration.patch again and copied the [0/n] changelog text into mm-memcontrol-rewrite-charge-api.patch. I'll get these (presently at http://ozlabs.org/~akpm/mmots/broken-out/) mm-memcontrol-rewrite-charge-api.patch mm-memcontrol-rewrite-uncharge-api.patch mm-memcontrol-rewrite-uncharge-api-fix-page-cache-migration.patch mm-memcontrol-use-page-lists-for-uncharge-batching.patch # page-cgroup-trivial-cleanup.patch page-cgroup-get-rid-of-nr_pcg_flags.patch # # memcg-remove-lookup_cgroup_page-prototype.patch on the wire tomorrow. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>