-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/31/2014 07:49 AM, Jerome Marchand wrote: > When memory cgoups are enabled, the code that decides to force to > scan anonymous pages in get_scan_count() compares global values > (free, high_watermark) to a value that is restricted to a memory > cgroup (file). It make the code over-eager to force anon scan. > > For instance, it will force anon scan when scanning a memcg that > is mainly populated by anonymous page, even when there is plenty of > file pages to get rid of in others memcgs, even when swappiness == > 0. It breaks user's expectation about swappiness and hurts > performance. > > This patch make sure that forced anon scan only happens when there > not enough file pages for the all zone, not just in one random > memcg. > > Signed-off-by: Jerome Marchand <jmarchan@xxxxxxxxxx> That fix is a lot smaller than I thought it would be. Nice. Reviewed-by: Rik van Riel <riel@xxxxxxxxxx> - -- All rights reversed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT2mL7AAoJEM553pKExN6DbzsH/ArKqWXYFfz7/hjADJXz85aK ygWdjpK18MbFeUMW3nL324j2567TXWpC2G7SgxSPjYnF/qvKjpoQHJk7WvisymjE p+5jGQAxzXgjlq0usGoFRrWUnR6vkdjTx0K8r6MO/asMLbvDBjkXvaURHdcV6fx4 nUbkF/GRXGAGcnHOEks294w+8j8R50bugnX+IfmKo73eteNcMWU7Ga+b93kUmz3p 4EE2PRpRKFWtpTAhpFlFI46gfu+e7I1Ziu2pzNUlYOP3P7t9pRS8YOI5JNOnyDfi lrbOXzoSqs6sbIlDd//A/p7u6Pzr+HnpbaxCrf9UCdNaMMqvb0gDQWv7221gI24= =BfHz -----END PGP SIGNATURE----- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>