On Tue 15-07-14 14:19:35, Michal Hocko wrote:
> [...]
> > +/**
> > + * mem_cgroup_migrate - migrate a charge to another page
> > + * @oldpage: currently charged page
> > + * @newpage: page to transfer the charge to
> > + * @lrucare: page might be on LRU already
>
> which one? I guess the newpage?
>
> > + *
> > + * Migrate the charge from @oldpage to @newpage.
> > + *
> > + * Both pages must be locked, @newpage->mapping must be set up.
> > + */
> > +void mem_cgroup_migrate(struct page *oldpage, struct page *newpage,
> > + bool lrucare)
> > +{
> > + unsigned int nr_pages = 1;
> > + struct page_cgroup *pc;
> > +
> > + VM_BUG_ON_PAGE(!PageLocked(oldpage), oldpage);
> > + VM_BUG_ON_PAGE(!PageLocked(newpage), newpage);
> > + VM_BUG_ON_PAGE(PageLRU(oldpage), oldpage);
> > + VM_BUG_ON_PAGE(PageLRU(newpage), newpage);
>
> VM_BUG_ON_PAGE(PageLRU(newpage) && !lruvec, newpage);
I guess everything except these two notes got addressed.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>