On Thu, 17 Jul 2014, Michal Hocko wrote: > On Thu 17-07-14 09:26:04, Johannes Weiner wrote: > > From bbe8c1645c77297a96ecd5d64d659ddcd6984d03 Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner <hannes@xxxxxxxxxxx> > > Date: Mon, 14 Jul 2014 08:51:54 -0400 > > Subject: [patch] mm: vmscan: clean up struct scan_control > > > > Reorder the members by input and output, then turn the individual > > integers for may_writepage, may_unmap, may_swap, compaction_ready, > > hibernation_mode into bit fields to save stack space: > > > > +72/-296 -224 > > kswapd 104 176 +72 > > try_to_free_pages 80 56 -24 > > try_to_free_mem_cgroup_pages 80 56 -24 > > shrink_all_memory 88 64 -24 > > reclaim_clean_pages_from_list 168 144 -24 > > mem_cgroup_shrink_node_zone 104 80 -24 > > __zone_reclaim 176 152 -24 > > balance_pgdat 152 - -152 > > > > Suggested-by: Mel Gorman <mgorman@xxxxxxx> > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > Looks nice to me. > Acked-by: Michal Hocko <mhocko@xxxxxxx> Yes, looks nice to me too; and I agree that it was worthwhile to make those initialization orders consistent, and drop the 0 initializations. Acked-by: Hugh Dickins <hughd@xxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>