On Mon, Jul 07, 2014 at 05:57:49PM +0200, Vlastimil Babka wrote: > On 07/04/2014 09:57 AM, Joonsoo Kim wrote: > >When isolating free page, what we want to know is which list > >the page is linked. If it is linked in isolate migratetype buddy list, > >we can skip watermark check and freepage counting. And if it is linked > >in CMA migratetype buddy list, we need to fixup freepage counting. For > >this purpose, get_onbuddy_migratetype() is more fit and cheap than > >get_pageblock_migratetype(). So use it. > > Hm but you made get_onbuddy_migratetype() work only with > CONFIG_MEMORY_ISOLATION. And __isolate_free_page is (despite the > name) not at all limited to CONFIG_MEMORY_ISOLATION. get_onbuddy_migratetype() is only used for determining whether this page is on isolate buddy list or not. So if !CONFIG_MEMORY_ISOLATION, default value of get_onbuddy_migratetype() makes things correct. But, I should write some code comment. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>