Hello, On Fri, Jul 11, 2014 at 12:29:30PM -0500, Christoph Lameter wrote: > GFP_THISNODE is mostly used by allocators that need memory from specific > nodes. The use of numa_mem_id() there is useful because one will not > get any memory at all when attempting to allocate from a memoryless > node using GFP_THISNODE. As long as it's in allocator proper, it doesn't matter all that much but the changes are clearly not contained, are they? Also, unless this is done where the falling back is actually happening, numa_mem_id() seems like the wrong interface because you end up losing information of the originating node. Given that this isn't a wide spread use case, maybe we can do with something like numa_mem_id() as a compromise but if we're doing that let's at least make it clear that it's something ugly (give it an ugly name, not something as generic as numa_mem_id()) and not expose it outside allocators. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>