On 07/09/14 18:32, Christoph Lameter wrote: > On Wed, 9 Jul 2014, Andrey Ryabinin wrote: > >> To avoid false positive reports in kernel address sanitizer krealloc/kzfree >> functions shouldn't be instrumented. Since we want to instrument other >> functions in mm/util.c, krealloc/kzfree moved to slab_common.c which is not >> instrumented. >> >> Unfortunately we can't completely disable instrumentation for one function. >> We could disable compiler's instrumentation for one function by using >> __atribute__((no_sanitize_address)). >> But the problem here is that memset call will be replaced by instumented >> version kasan_memset since currently it's implemented as define: > > Looks good to me and useful regardless of the sanitizer going in. > > Acked-by: Christoph Lameter <cl@xxxxxxxxx> > I also noticed in mm/util.c: /* Tracepoints definitions. */ EXPORT_TRACEPOINT_SYMBOL(kmalloc); EXPORT_TRACEPOINT_SYMBOL(kmem_cache_alloc); EXPORT_TRACEPOINT_SYMBOL(kmalloc_node); EXPORT_TRACEPOINT_SYMBOL(kmem_cache_alloc_node); EXPORT_TRACEPOINT_SYMBOL(kfree); EXPORT_TRACEPOINT_SYMBOL(kmem_cache_free); Should I send another patch to move this to slab_common.c? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>